Skip to content

improvement(chat): nest folders inside their resources in the org resource menu - #8302

Merged
waleedlatif1 merged 2 commits into
stagingfrom
feat/resource-menu-folders
Sep 25, 2026
Merged

improvement(chat): nest folders inside their resources in the org resource menu#8302
waleedlatif1 merged 2 commits into
stagingfrom
feat/resource-menu-folders

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Org-view chat + menu no longer lists Files, File Folders, and Folders as separate families — it now opens per-workspace submenus, each rendering that workspace's foldered resource menu (folders live inside Workflows, Files, Tables, Knowledge Bases)
  • Reuses the existing WorkspaceResourceSubmenu from the org resource-tab picker, so both org menus share one workspace-first shape; adds a selectFolders prop so chat can still attach folders
  • Removes the flat mode from ResourceMenuSections — every caller now goes through the foldered path
  • Per-workspace trees are required because item/folder ids are only unique within a workspace, so the merged org inventory can't be foldered as one tree
  • Browser/Terminal stay as trailing platform entries; search and @ mentions still span every workspace

Type of Change

  • Improvement

Testing

Type-check, lint:check, check:audits (49 audits), block registry, and docs manifest checks pass. Existing resource-folder-tree and org-inventory tests pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 25, 2026 6:10pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 25, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread ...]/home/components/mothership-view/components/add-resource-dropdown/add-resource-dropdown.tsx
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Restructures resource menu to nest folders inside their resource types.

The PR appears safe to merge; no new actionable issue was established.

Summary

The PR changes the organization chat resource menu to open workspace-specific, foldered submenus while keeping Browser and Terminal as trailing entries. The change since the previous review adds a loading row while a workspace menu hydrates.

  • Workspace submenus reuse the resource picker and support selecting folders.
  • The loading row prevents an initially loading submenu from appearing empty.
Diagram 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Organization chat + menu] --> B[Workspace submenu]
  B --> C[Foldered resource sections]
  A --> D[Browser and Terminal]
  A --> E[Organization-wide search]
Loading

Reviews (2) · Last reviewed commit: "fix(chat): show a loading row while a wo..."

@greptile-apps

This comment has been minimized.

Sign in to view
@waleedlatif1

waleedlatif1 commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 25, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 7c115a1 into staging Sep 25, 2026
23 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/resource-menu-folders branch September 25, 2026 18:15
This was referenced Sep 25, 2026
Merged
Closed

This branch was previously deployed

1 inactive deployment
Preview — e2fc80c6 Deployed Sep 25, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1